Maor Lipchuk has posted comments on this change.
Change subject: core, restapi: Convert NFS version to enum
......................................................................
Patch Set 8: I would prefer that you didn't submit this
(4 inline comments)
The following dao tests will fail: StorageServerConnectionDAOTest.testGetForIqn
StorageServerConnectionDAOTest.testgetAll
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java
Line 30:
Line 31: dao = prepareDAO(dbFacade.getStorageServerConnectionDao());
Line 32:
Line 33: existingConnection =
dao.get("0cc146e8-e5ed-482c-8814-270bc48c297f");
Line 34: existingNfsAutoConnection =
dao.get("0cc146e8-e5ed-482c-8814-270bc48c2981");
Consider using FixturesTool class for the new Guid
Line 35:
Line 36: newServerConnection = new storage_server_connections();
Line 37:
newServerConnection.setid("0cc146e8-e5ed-482c-8814-270bc48c2980");
Line 38:
newServerConnection.setconnection(EXISTING_DOMAIN_STORAGE_NAME);
Line 66: assertNull(result);
Line 67: }
Line 68:
Line 69: @Test
Line 70: public void testGetForIqn() {
This test will fail since your iqn is null, which is the same as in the
"existingConnection".
Line 71: storage_server_connections result =
dao.getForIqn(existingConnection.getiqn());
Line 72:
Line 73: assertNotNull(result);
Line 74: assertEquals(existingConnection, result);
Line 81: public void testgetAll() {
Line 82: List<storage_server_connections> result = dao.getAll();
Line 83:
Line 84: assertNotNull(result);
Line 85: assertFalse(result.isEmpty());
You added a new connection, so now SERVER_CONNECTION_COUNT should have 9
connections.
Line 86: assertEquals(SERVER_CONNECTION_COUNT, result.size());
Line 87: }
Line 88:
Line 89: /**
....................................................
Commit Message
Line 6:
Line 7: core, restapi: Convert NFS version to enum
Line 8:
Line 9: In order to support optional advanced nfs options, the "auto" version
Line 10: specifier must be distinct from "not set" in the the database.
Instead,
s/in the the/in the
Line 11: "auto" will be explicit as a string, and "not set" will be null. This
Line 12: change requires the core and rest api to propagate non-numeric version
Line 13: values as well.
Line 14:
--
To view, visit http://gerrit.ovirt.org/8797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09d82db7c0ec92135cae8935f013487e97b8f357
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
