Alon Bar-Lev has posted comments on this change. Change subject: packaging: Stopped engine before restoring orig configuration ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 879: finally: Line 880: # Restore previous engine configuration Line 881: utils.restoreEngineFromMaintenance() Line 882: # Stop the engine first Line 883: stopEngine(service) shouldn't this be before the above line? Line 884: if origTimeout != 0: Line 885: utils.configureTasksTimeout(origTimeout) Line 886: Line 887: -- To view, visit http://gerrit.ovirt.org/8935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47acf36a819da2d431731828b6b85478325c0b4e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
