Yair Zaslavsky has posted comments on this change. Change subject: tools: rhevm-manage-domains -passwordFile=<existing empty file> throws exception (#870052) ......................................................................
Patch Set 1: (1 inline comment) Please see comments for commit message. The code looks good. .................................................... Commit Message Line 3: AuthorDate: 2012-11-01 00:22:13 -0400 Line 4: Commit: Ravi Nori <[email protected]> Line 5: CommitDate: 2012-11-01 00:24:58 -0400 Line 6: Line 7: tools: rhevm-manage-domains -passwordFile=<existing empty file> throws exception (#870052) I suspect the commit msg is too long. 1. No need to mention the bug number at the title, you have Bug-Url for that (this is an "old format of commit msg" behavior). 2. It's perfectly fine not to include the entire bug title 3. At open source you should not mention rhevm. I suggest the title will be: tool: fixing handling empty password file at engine-manage-domains Line 8: Line 9: When running rhevm-manage-domains with -passwordFile=pass, a NullPointerException is Line 10: thrown when the passowrd file exists but is empty. Line 11: -- To view, visit http://gerrit.ovirt.org/8965 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3b6ffcad4ae402ffce2adcaf023068da024ee81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
