Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Add/Edit logical networks- tooltip for disables checkboxes ......................................................................
webadmin: Add/Edit logical networks- tooltip for disables checkboxes - If VM Networks checkbox is disabled, tooltip should be displayed- Brigless networks are not supported for Cluster version x.x - If override MTU is disabled, tooltip should be displayed- MTU override is not supported for Cluster version x.x Change-Id: Ibf0f34d1dc6e9927e08a152c90c3748ccb536639 Signed-off-by: Alona Kaplan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/02/9002/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java index 752b93f..5545e6b 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java @@ -233,6 +233,9 @@ this.isSupportBridgesReportByVDSM = isSupportBridgesReportByVDSM; if (!isSupportBridgesReportByVDSM) { getIsVmNetwork().setEntity(true); + getIsVmNetwork().getChangeProhibitionReasons().add(ConstantsManager.getInstance() + .getMessages() + .bridlessNetworkNotSupported(getSelectedDc().getcompatibility_version().toString())); getIsVmNetwork().setIsChangable(false); }else{ getIsVmNetwork().setIsChangable(true); @@ -248,6 +251,9 @@ public void setMTUOverrideSupported(boolean mtuOverrideSupported) { this.mtuOverrideSupported = mtuOverrideSupported; if (!mtuOverrideSupported) { + getHasMtu().getChangeProhibitionReasons().add(ConstantsManager.getInstance() + .getMessages() + .mtuOverrideNotSupported(getSelectedDc().getcompatibility_version().toString())); getHasMtu().setIsChangable(false); getMtu().setIsChangable(false); getHasMtu().setEntity(false); diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java index 8bbefbd..a12f356 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java @@ -189,4 +189,10 @@ @DefaultMessage("Vnic {0} from Template {1}") String vnicFromTemplate(String vnic, String template); + + @DefaultMessage("Brigless networks are not supported for Cluster version {0}") + String bridlessNetworkNotSupported(String version); + + @DefaultMessage("MTU override is not supported for Cluster version {0}") + String mtuOverrideNotSupported(String version); } -- To view, visit http://gerrit.ovirt.org/9002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf0f34d1dc6e9927e08a152c90c3748ccb536639 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
