Maor Lipchuk has posted comments on this change.
Change subject: core: LSM - rollback on non-running VM
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java
Line 33:
Line 34: public LiveMigrateDiskCommand(T parameters) {
Line 35: super(parameters);
Line 36:
Line 37: if (VMStatus.Up != getVm().getstatus()) {
I would add the following condition VMStatus.Up != getVm().getstatus()), only
for setting the parameters.
The call to internalEndFailure should be from endSuccesfully.
I think Calling logic from the constructor is wrong.
Line 38: internalEndFailure();
Line 39: return;
Line 40: }
Line 41:
--
To view, visit http://gerrit.ovirt.org/8998
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7aafc5cd63f961470124c984afb2e7a9d74a0de2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
