Liron Aravot has posted comments on this change.
Change subject: core: Quota refactor - test and commands I
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 291:
Line 292: @Override
Line 293: public List<QuotaStorageConsumptionParameter>
getQuotaStorageConsumptionParameters() {
Line 294: List<QuotaStorageConsumptionParameter> list = new
ArrayList<QuotaStorageConsumptionParameter>();
Line 295: for (DiskImage disk : getDisksList()) {
can you please add a helper method for performing it? this code is repeating
itself in all of this patch edited classes.
Line 296: list.add(new QuotaStorageConsumptionParameter(
Line 297: disk.getQuotaId(),
Line 298: null,
Line 299: QuotaConsumptionParameter.QuotaAction.CONSUME,
--
To view, visit http://gerrit.ovirt.org/9001
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28dc5d1cf3a29d2f3314429e0081758bf3582f27
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Noam Slomianko <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
