Arik Hadas has uploaded a new change for review.
Change subject: engine: Remove unnecessary if clause
......................................................................
engine: Remove unnecessary if clause
Modified an if-else statement of the following structure:
if (A) {
...
}
else if (!A) {
...
}
To:
if (A) {
...
}
else {
...
}
Change-Id: I1ea9acbf5dce7608660fa7a8055eb4c6f45c2526
Signed-off-by: Arik Hadas <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/9014/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java
index 8b3e625..aef680c 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VDSBrokerFrontendImpl.java
@@ -52,7 +52,7 @@
if (prevCommand != null && !prevCommand.equals(command)) {
prevCommand.reportCompleted();
}
- } else if (!result.getSucceeded()) {
+ } else {
throw new VdcBLLException(result.getVdsError().getCode(),
result.getExceptionString());
}
--
To view, visit http://gerrit.ovirt.org/9014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ea9acbf5dce7608660fa7a8055eb4c6f45c2526
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches