Roy Golan has posted comments on this change.
Change subject: core: Libosinfo service Xml loading impl
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/services/libosinfo/interface/src/main/java/org/ovirt/engine/core/services/libosinfo/LibosinfoServiceXmlImpl.java
Line 20:
Line 21: INSTANCE;
Line 22:
Line 23: private final String i386 = "i386";
Line 24: private final String x86_64 = "x86_64";
I've replaced those with CpuArch enum
Line 25:
Line 26: private Map<String, Os> all;
Line 27:
Line 28: private Map<String, Os> osInfoMap = new HashMap<String, Os>();
Line 86: public long getRecommendedRam(VmOsType os) {
Line 87: return getResource(os.getShortId(),
os.getIs64Bit()).getRecommended().getRam();
Line 88: }
Line 89:
Line 90: private Resources getResource(String shortId, boolean is64Bit) {
I agree. Resources is a generated bean from the /usr/share/libosinfo/data/oses.
it is a an xml complex type. I can tweak the the xsd to change it I believe
Line 91: String arch = is64Bit ? x86_64 : i386;
Line 92: Os os = getByShortId(shortId);
Line 93: if (os != null) {
Line 94: for (Resources resource : os.getResources()) {
--
To view, visit http://gerrit.ovirt.org/8473
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d4c764948f714173306ceb758e0334f05fc9527
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
