Liron Aravot has posted comments on this change.
Change subject: core : WIP : Preview snapshot - NPE after engine crash
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
Line 85: protected void endSuccessfully() {
Line 86: endActionOnDisks();
Line 87:
Line 88: if (getVm() != null) {
Line 89: VmHandler.unlockVm(getVm(), getCompensationContext());
reset the compensation after the first task created won't help in that case and
will just cause inconsistency or redundant checks. - there is no meaning to
the new active snapshot in preview with only some of the disks. if
endSuccesfully would be called and succeed when there were tasks for only part
of disks it won't be actually a preview as some of the disks won't be in the
new snapshot which will cause to either inconsistent data on disk or bad user
experience (won't have some of his disks on the preview). this is not the
solution on this case at the moment.
Line 90: // TODO : this line is temporary until AsyncTaskManager
issues (missing tasks) would be solved,
Line 91: // as of today - endSuccessfully() will be called also in
case that tasks were initiated for some of the
Line 92: // disks regardless if there was a failure during the
initializtion of it.
Line 93: if
(getSnapshotDao().get(((ImagesActionsParametersBase)getParameters().getImagesParameters().get(0)).getVmSnapshotId())
!= null) {
--
To view, visit http://gerrit.ovirt.org/9073
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4ddecc990fbca23fb98e8ab42cb1eb039e1fb59
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
