Shireesh Anjal has posted comments on this change.
Change subject: engine: Removed unnecessary 'continue' statements
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java
Line 188:
Line 189: try {
Line 190: removeServerFromDb(server);
Line 191: // remove the server from resource manager
Line 192: runVdsCommand(VDSCommandType.RemoveVds, new
RemoveVdsVDSCommandParameters(server.getId()));
I think removing the "from database!" part of the error message would do. The
log message then would be generic, and the actual exception being logged will
be specific - so no issues. I'll do this in a separate patch as this patch is
already merged.
Line 193: } catch (Exception e) {
Line 194: log.errorFormat("Error while removing server {0}
from database!", server.getvds_name(), e);
Line 195: }
Line 196: }
--
To view, visit http://gerrit.ovirt.org/9083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b93b739db7d41384cf6455e43e0b4f3182d2ff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
