Arik Hadas has posted comments on this change.
Change subject: core: use String instead of StringBuilder in SysprepHandler
(#873742)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java
Line 63: passwordPerDomain = Config.<DomainsPasswordMap>
GetValue(ConfigValues.AdUserPassword);
Line 64: }
Line 65:
Line 66: public static String GetSysPrep(VM vm, String hostName, String
domain, SysPrepParams sysPrepParams) {
Line 67: String sysPrepContent = "";
it would also mean to change LoadFile(..) method so that it will return null in
case of an error loading the file.. I think it's better to keep it as ""..
Line 68: switch (vm.getStaticData().getos()) {
Line 69: case WindowsXP:
Line 70: sysPrepContent = LoadFile(Config.<String>
GetValue(ConfigValues.SysPrepXPPath));
Line 71: sysPrepContent = replace(sysPrepContent, "$ProductKey$",
Config.<String> GetValue(ConfigValues.ProductKey));
--
To view, visit http://gerrit.ovirt.org/9102
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie447c30759d19e4d42a722deb550a6233becb490
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
