Omer Frenkel has posted comments on this change.
Change subject: tools: engine-config need to remove all ver 2.2 values
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 311
Line 312
Line 313
Line 314
Line 315
if a message is not used anymore, it should be removed from VdcBllMessages and
properties file, this is relevant also for other checks that were removed in
this patch
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
Line 190: .RunVdsCommand(VDSCommandType.FormatStorageDomain,
Line 191: new
FormatStorageDomainVDSCommandParameters(vds.getId(),
dom.getId())).getSucceeded();
Line 192: }
Line 193:
Line 194: protected boolean removeStorage(storage_domains dom, VDS vds) {
i think this method can be removed completely.
Line 195: return true;
Line 196: }
Line 197:
Line 198: @Override
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 899:
Line 900: @Reloadable
Line 901: @TypeConverterAttribute(Boolean.class)
Line 902: @DefaultValueAttribute("true")
Line 903: SupportCustomProperties(289),
if a config is not in use anymore, and removed completely from the options
table, it should be removed from here as well (this is relevant also for other
config values removed in this patch)
Line 904:
Line 905: @Reloadable
Line 906: @TypeConverterAttribute(Boolean.class)
Line 907: @DefaultValueAttribute("true")
--
To view, visit http://gerrit.ovirt.org/9131
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08cccaa4724ae84785fa0f3d5ea4141626c0f575
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
