Maor Lipchuk has submitted this change and it was merged. Change subject: core: NPEs in AddVmTemplate end methods after engine crash ......................................................................
core: NPEs in AddVmTemplate end methods after engine crash AddVmTemplateCommand endSuccesfully() method had 2 NPEs after engine crash occrured. 1. VmTemplateId wasn't set after loading the async task info because of wrong setter name 2. getVm() returned null because vm id is not set per the parent command parameters. Change-Id: I12c40cd3736a0516473de223ec84301f84983d3b Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Vered Volansky: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/9106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c40cd3736a0516473de223ec84301f84983d3b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
