Eli Mesika has uploaded a new change for review. Change subject: core:Fence Host fails if something ...(#871768) ......................................................................
core:Fence Host fails if something ...(#871768) Fence Host fails if something went wrong in FenceQuietTimeBetweenOperationsInSec window [180seconds] We have a configuration setting of Quiet Time Between PM Operations, this should control PM operations invoked by the user. The intension is to prevent subsequent calls to PM stop/start without waiting to a stable status. Adding a condition in the FenceVdsBaseCommand canDoAction validation , not to check Quiet Time Between PM Operations if the command is internal (i.e. was invoked by the system and not by the user) Change-Id: I2cab006a6e911d1eaad888c5c4e41bb4aca68f03 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/11/9211/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java index 1afc6bd..963cf3e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java @@ -100,8 +100,8 @@ .AddSeconds((Integer) Config.GetValue(ConfigValues.DisableFenceAtStartupInSec)); java.util.Date now = new java.util.Date(); if (waitTo.before(now) || waitTo.equals(now)) { - // Check Quiet time between PM operations, this is done only if parent command is not <Restart> - int secondsLeftToNextPmOp = ((getParameters().getParentCommand() == VdcActionType.RestartVds)) + // Check Quiet time between PM operations, this is done only if command is not internal and parent command is not <Restart> + int secondsLeftToNextPmOp = (isInternalExecution() || (getParameters().getParentCommand() == VdcActionType.RestartVds)) ? 0 : -- To view, visit http://gerrit.ovirt.org/9211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2cab006a6e911d1eaad888c5c4e41bb4aca68f03 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
