Juan Hernandez has posted comments on this change. Change subject: Packaging: inrecursive ownership of backend package on backups directory. ......................................................................
Patch Set 1: (2 inline comments) The change looks good to me, I only have some suggestions for the commit message. .................................................... Commit Message Line 3: AuthorDate: 2012-11-13 15:40:19 +0200 Line 4: Commit: Ohad Basan <[email protected]> Line 5: CommitDate: 2012-11-13 15:44:38 +0200 Line 6: Line 7: Packaging: inrecursive ownership of backend package on backups directory. We use to write "packaging" all lower case. I would rather use "Fix double ownership of backups directory". Line 8: Line 9: Currently rpm installation of ovirt on fedora18 fails due to dual Line 10: package ownership of the backups directory. Line 11: this package changes the ownership of the directory to -backend Line 7: Packaging: inrecursive ownership of backend package on backups directory. Line 8: Line 9: Currently rpm installation of ovirt on fedora18 fails due to dual Line 10: package ownership of the backups directory. Line 11: this package changes the ownership of the directory to -backend This change fixes the ownership .... Line 12: Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=876164 Line 14: Change-Id: I57144d53cc672e3a75089b932e49af98751ed564 -- To view, visit http://gerrit.ovirt.org/9216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57144d53cc672e3a75089b932e49af98751ed564 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
