Ohad Basan has posted comments on this change. Change subject: packaging: change handling of sysctl.conf ......................................................................
Patch Set 3: (3 inline comments) .................................................... Commit Message Line 7: packaging: change refence to new sysctl.conf location Line 8: Line 9: in fedora 18 the location of /etc/sysctl.conf had changed to Line 10: /usr/lib/sysctl.d/00-system.conf Line 11: This patch changes the reference to the correct file Done Line 12: Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=867833 Line 14: Change-Id: I9ca4988beea1627b2da442a7fcf8fef3cf3db6a5 .................................................... File packaging/fedora/setup/basedefs.py Line 105: FILE_VIRTIO_WIN_ISO="/usr/share/virtio-win/virtio-win.iso" Line 106: FILE_RHEV_GUEST_TOOLS_ISO="/usr/share/rhev-guest-tools-iso/rhev-tools-setup.iso" Line 107: FILE_SYSCTL="/etc/sysctl.conf" Line 108: DIR_SYSCTL="/etc/sysctl.d" Line 109: FILE_ENGINE_SYSCTL=os.path.join(DIR_SYSCTL,"00-ovirt-engine.conf") Done Line 110: Line 111: # ISO Line 112: ISO_DISPLAY_NAME = "ISO_DOMAIN" Line 113: DEFAULT_ISO_EXPORT_PATH = "/var/lib/exports/iso" .................................................... File packaging/fedora/setup/engine-setup.py Line 1623: if currentShmmax and (int(currentShmmax) >= basedefs.CONST_SHMMAX): Line 1624: logging.debug("current shared memory max in kernel is %s, there is no need to update the kernel parameters", currentShmmax) Line 1625: return Line 1626: Line 1627: # In some systems the sysctl file doesn't exist, so we may need to create it: Done Line 1628: if not os.path.exists(basedefs.FILE_SYSCTL): Line 1629: open(basedefs.FILE_ENGINE_SYSCTL, "w").close() Line 1630: Line 1631: # If we got here, it means we need to update kernel.shmmax in sysctl.conf -- To view, visit http://gerrit.ovirt.org/8705 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ca4988beea1627b2da442a7fcf8fef3cf3db6a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
