Omer Frenkel has posted comments on this change. Change subject: engine: re-run mechanism improvements ......................................................................
Patch Set 2: (1 inline comment) looks good, minor comment .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java Line 234: // mark previous steps as fail Line 235: JobRepositoryFactory.getJobRepository().closeCompletedJobSteps(job.getId(), JobExecutionStatus.FAILED); Line 236: } Line 237: } Line 238: // set the _isRerun flag to false before calling executeAction to that we'll know if typo: "..so that.." Line 239: // there is another rerun attempt within the method Line 240: _isRerun = false; Line 241: executeAction(); Line 242: -- To view, visit http://gerrit.ovirt.org/9184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557636a94d74772635102c6a33dc923d91332a3e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
