Sharad Mishra has posted comments on this change.
Change subject: utils: tar: throw an exception if base does not exist
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
one minor formatting comment inline.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java
Line 91: public static void doTar(
Line 92: OutputStream os,
Line 93: File base
Line 94: ) throws SecurityException, IOException {
Line 95:
no need for the extra line here.
Line 96: if (!base.exists()) {
Line 97: throw new FileNotFoundException(
Line 98: String.format(
Line 99: "File or directory %1$s not found",
--
To view, visit http://gerrit.ovirt.org/9165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25e4e41f7c68c9a6b797b7436c8565d2ad059329
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
