Allon Mureinik has posted comments on this change. Change subject: core: set storage domain format V3 for DC 3.2 ......................................................................
Patch Set 2: Looks good to me, approved I'd extract the result of compareTo to a variable, and change the order so you can read the fallthrough (v3, then v2, then v1), but not sure it's worth the hassle. please verify so this patch can be merged. -- To view, visit http://gerrit.ovirt.org/9249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fe0bde2616bb393b2d3c15da0b216531f58e54f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
