Shireesh Anjal has posted comments on this change.
Change subject: core: WIP: Update StoragePoolValidator test to test GlusterFS.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java
Line 54: if (storagePool.getstorage_pool_type() == StorageType.GLUSTERFS
Line 55: && !this.<Boolean>
getConfigValue(ConfigValues.GlusterFsStorageEnabled,
Line 56: storagePool.getcompatibility_version()
Line 57: .toString())) {
Line 58:
canDoActionMessages.add(VdcBllMessages.DATA_CENTER_POSIX_STORAGE_NOT_SUPPORTED_IN_CURRENT_VERSION.toString());
IMHO it is still better to have a separate enum, as the mapped messages in
properties files can change in future. Maybe you can make the existing message
more specific to POSIXFS, and introduce a new one specific to GLUSTERFS, in
this patch itself? I think it will make it clearer to the user as to what
exactly is not supported.
Line 59: return false;
Line 60: }
Line 61: return true;
Line 62: }
--
To view, visit http://gerrit.ovirt.org/8836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4cd98cd06716c31248d8ec4f21a3a6f79f13102
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
