Allon Mureinik has posted comments on this change.
Change subject: core: Disallow removing of a DC when not all hosts are in
maintenance (#850286)
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
Line 332: }
Line 333: }
Line 334: else {
Line 335: List<VDS> poolHosts =
Line 336:
DbFacade.getInstance().getVdsDao().getAllForStoragePool(getParameters().getStoragePoolId());
use getVdsDao()
Line 337:
Line 338: sharedLocks = new HashMap<String, String>();
Line 339: for (VDS host : poolHosts) {
Line 340: sharedLocks.put(host.getId().toString(),
LockingGroup.VDS.name());
--
To view, visit http://gerrit.ovirt.org/9110
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88e2938d4c1b02065b330929e15c579f714e4385
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
