Dhandapani Gopal has posted comments on this change.

Change subject: engine: Gluster Peer Detach bll command
......................................................................


Patch Set 5: (2 inline comments)

Incorporated review comments.

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/RemoveGlusterServerParameters.java
Line 9: public class RemoveGlusterServerParameters extends 
VdcActionParametersBase {
Line 10:     private static final long serialVersionUID = -1224829720081853632L;
Line 11: 
Line 12:     private String hostnameOrIp;
Line 13:     private boolean forceAction;
Done
Line 14: 
Line 15:     public RemoveGlusterServerParameters(String hostnameOrIp, boolean 
forceAction) {
Line 16:         setHostnameOrIp(hostnameOrIp);
Line 17:         setForceAction(forceAction);


....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 554: GLUSTER_VOLUME_REPLACE_BRICK_START=Gluster Volume 
${glusterVolumeName} Replace Brick started.
Line 555: GLUSTER_VOLUME_REPLACE_BRICK_START_FAILED=Could not start Gluster 
Volume ${glusterVolumeName} Replace Brick.
Line 556: GLUSTER_HOST_ADD_FAILED=Failed to add gluster server ${VdsName} into 
Cluster ${VdsGroupName}.
Line 557: GLUSTER_SERVER_REMOVE=Gluster server ${VdsName} removed from Cluster 
${VdsGroupName}.
Line 558: GLUSTER_SERVER_REMOVE_FAILED=Failed to remove gluster server 
${VdsName} from Cluster ${VdsGroupName}.
Added custom value to ${VdsName}.
Line 559: GLUSTER_SERVERS_LIST_FAILED=Failed to fetch gluster peer list from 
server ${VdsName} on Cluster ${VdsGroupName}.
Line 560: HA_VM_FAILED=Highly Available VM ${VmName} failed. It will be 
restarted automatically.
Line 561: HA_VM_RESTART_FAILED=Restart of the Highly Available VM ${VmName} 
failed.
Line 562: GLUSTER_VOLUME_PROFILE_START=Gluster Volume ${glusterVolumeName} 
Profile started.


--
To view, visit http://gerrit.ovirt.org/9044
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I171f1b6eb9d01f1ffb2b4a0be52a15887f534c2d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to