Kanagaraj M has posted comments on this change.
Change subject: webadmin,userportal: Improve UI code performance
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
one minor comment.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 404: pmOptions += k + ","; //$NON-NLS-1$
Line 405: }
Line 406: else
Line 407: {
Line 408: pmOptions += k + "=" + v + ","; //$NON-NLS-1$
//$NON-NLS-2$
You could use StringBuilder here as the string manipulation happening inside
the loop.
Line 409: }
Line 410: }
Line 411: }
Line 412:
--
To view, visit http://gerrit.ovirt.org/9365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I264952895c33454e925ca2c109dd019a61aab879
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
