Ofer Schreiber has posted comments on this change. Change subject: packaging: Bump package version to 3.2.0 ......................................................................
Patch Set 1: (1 inline comment) +1 on the need to bump version (added few falks from engine to review). Small comment inside, thus I'm waiting with the +1/+2 .................................................... File Makefile Line 50: RPM_VERSION:=$(shell echo $(APP_VERSION) | sed "s/-/_/") Line 51: Line 52: # Release Version; used to create y in <x.x.x-y> numbering. Line 53: # Should be used to create releases. Line 54: RPM_RELEASE_VERSION=0.1.$(shell date +%Y%m%d)git$(shell git log --format=%h -1) Although it sounds minor, I remember a bug about forcing users to have the git in order to build the rpm. what happens if someone download the tarball without the complete git? Line 55: Line 56: SPEC_FILE_IN=packaging/fedora/spec/ovirt-engine.spec.in Line 57: SPEC_FILE=$(PACKAGE_NAME).spec Line 58: OUTPUT_RPMBUILD=$(shell pwd -P)/tmp.rpmbuild -- To view, visit http://gerrit.ovirt.org/8993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id39be86095362259e2e44aba1517fe9564dea956 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Kiril Nesenko <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Ohad Basan <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
