Oved Ourfali has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
......................................................................
Patch Set 8: (1 inline comment)
minor comment.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java
Line 31: private String userName;
Line 32: private final String domainName;
Line 33: private final LdapProviderType ldapProviderType;
Line 34: private final StringBuffer userGuid;
Line 35: private DnsSRVResult ldapDnsResult;
You haven't added the final....
Line 36: private final static Logger log =
Logger.getLogger(JndiAction.class);
Line 37:
Line 38: public JndiAction(String userName, String domainName, StringBuffer
userGuid, LdapProviderType ldapProviderType, DnsSRVResult ldapDnsResult) {
Line 39: this.userName = userName;
--
To view, visit http://gerrit.ovirt.org/9349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5132300eb1f1fd94f771cab17efe5246dbeca8
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
