Allon Mureinik has posted comments on this change. Change subject: core: validate max lun disk attachment ......................................................................
Patch Set 3: Looks good to me, but someone else must approve Generally like all the changes here, also I'd separate this patch into two patches - cleanups/refactoring and the additional logic. Also, a test would be great. Regarding naming conventions - please don't use assertXYZ - it's usually only used in unit test context, and may be confusing. I'm fine with either of the other conventions suggested here. -- To view, visit http://gerrit.ovirt.org/9409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a82b3ed85c89beb8df70315ad457f54b366d69d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
