Alon Bar-Lev has posted comments on this change. Change subject: packaging: Create systemd unit dir in the Makefile ......................................................................
Patch Set 2: (1 inline comment) Minor comment... if you disagree go with this. .................................................... File Makefile Line 29: PREFIX=/usr/local Line 30: LOCALSTATE_DIR=$(PREFIX)/var Line 31: ENGINE_STATE=$(LOCALSTATE_DIR)/lib/$(ENGINE_NAME) Line 32: BIN_DIR=$(PREFIX)/bin Line 33: SYSTEMD_UNIT_DIR=$(PREFIX)/lib/systemd/system I still think this should not be under PREFIX... it is of systemd... unless you want to install this somewhere within our tree and symlink it at spec file? Line 34: SYSCONF_DIR=$(PREFIX)/etc Line 35: DATAROOT_DIR=$(PREFIX)/share Line 36: MAN_DIR=$(DATAROOT_DIR)/man Line 37: DATA_DIR=$(DATAROOT_DIR)/$(ENGINE_NAME) -- To view, visit http://gerrit.ovirt.org/9427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f378d7397f1b45497b890a8920f8c5e2bbc17b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
