Mike Kolesnik has posted comments on this change. Change subject: core: adding "linked" property to VmNetworkInterface ......................................................................
Patch Set 5: (1 inline comment) Basically +2 but please fix the field doc .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java Line 29: private String vmName; Line 30: private NGuid vmTemplateId; Line 31: /* status of the nic. Active nic is one that is plugged to its VM */ Line 32: private boolean active = true; Line 33: /* link state of the nic */ Can you please elaborate? Also better have it as javadoc and with proper English (capitalization, punctuation) Line 34: private boolean linked = true; Line 35: private boolean portMirroring; Line 36: Line 37: private static final ArrayList<String> _changeablePropertiesList = -- To view, visit http://gerrit.ovirt.org/9440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c8d965b66201506d7e4b82d5b53012fd0bf7d61 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
