Allon Mureinik has posted comments on this change.
Change subject: tools: engine-config cleanup 2.2 SupportStorageFormat
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainTest.java
Line 49: import org.ovirt.engine.core.utils.MockEJBStrategyRule;
Line 50:
Line 51: @RunWith(MockitoJUnitRunner.class)
Line 52: public class RemoveStorageDomainTest {
Line 53: private static final Version VDS_COMPATIBILITY_VERSION = new
Version(2, 2);
IIUC, after this patch, you will have removed all the 2.2 references from
RemoveStorageDomainCommand, so this constant should probably be removed.
Line 54:
Line 55: @Rule
Line 56: public MockEJBStrategyRule mockEjbRule = new MockEJBStrategyRule();
Line 57:
Line 285:
Line 286: protected VDS getVds(Guid id) {
Line 287: VDS vds = new VDS();
Line 288: vds.setId(id);
Line 289:
vds.setvds_group_compatibility_version(VDS_COMPATIBILITY_VERSION);
See comment above - this is probably no longer relevant for this test.
Line 290: return vds;
Line 291: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetVGInfoVDSCommandParameters.java
Line 1: package org.ovirt.engine.core.common.vdscommands;
Line 2:
Line 3: import org.ovirt.engine.core.compat.*;
while you're at it, consider replacing the * import with FQCN imports.
Line 4:
Line 5: public class GetVGInfoVDSCommandParameters extends
VdsIdVDSCommandParametersBase {
Line 6: private String privateVGID;
Line 7:
--
To view, visit http://gerrit.ovirt.org/9490
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I892af2405d55233e465f2d0da1cd4f0378076c88
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
