Sharad Mishra has posted comments on this change.
Change subject: engine: Require Permissions on Network
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
Line 262:
Line 263: Network network =
getNetworkDAO().getByNameAndCluster(getNetworkName(),
getVm().getvds_group_id());
Line 264: permissionList.add(new PermissionSubject(network == null
? null : network.getId(),
Line 265: VdcObjectType.Network,
Line 266: ActionGroup.CONFIGURE_VM_NETWORK));
should we create the PermissionSubject object even for a 'null' Network?
Line 267:
Line 268: if (getParameters().getInterface().isPortMirroring()) {
Line 269: permissionList.add(new PermissionSubject(network ==
null ? null : network.getId(),
Line 270: VdcObjectType.Network,
--
To view, visit http://gerrit.ovirt.org/9544
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife019f6195b8a8c09e7dba989f37f150700dbaea
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
