Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: don't iterate map ketSet()
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 248: // MoveOrCopyAllImageGroups();
Line 249: image.setstorage_ids(new
ArrayList<Guid>(Arrays.asList(getParameters().getSourceDomainId())));
Line 250: }
Line 251: if (retVal) {
Line 252: Map<Guid, List<DiskImage>> images =
getImagesLeaf(getVm().getImages());
good point, will fix.
Line 253: for (Map.Entry<Guid, List<DiskImage>> entry :
images.entrySet()) {
Line 254: Guid id = entry.getKey();
Line 255: List<DiskImage> diskList =
entry.getValue();
Line 256: getVm().getDiskMap().put(id,
diskList.get(diskList.size() - 1));
--
To view, visit http://gerrit.ovirt.org/9616
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I687810d5619603aab135a7d5d8e8fcef11685e9a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
