Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmTemplateInterfaceCommand (wip)
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java
Line 85: boolean unlinkingSupported =
Line 86: Config.<Boolean>
GetValue(ConfigValues.NetworkLinkingSupported,
Line 87:
getVdsGroup().getcompatibility_version().getValue());
Line 88:
Line 89: if (!unlinkingSupported) {
those 2 can-do-actions validations are quite repetitive in the code.
How about extracting them into a NetworkValidator class and reuse it?
See as example StorageDomainValidator.
Line 90: if (!getParameters().getInterface().isLinked()) {
Line 91:
addCanDoActionMessage(VdcBllMessages.UNLINKING_IS_NOT_SUPPORTED);
Line 92: addCanDoActionMessage(String.format("$clusterVersion
%1$s",
Line 93:
getVdsGroup().getcompatibility_version().getValue()));
....................................................
Commit Message
Line 5: CommitDate: 2012-11-29 17:18:37 +0200
Line 6:
Line 7: core: add NetworkLinking to AddVmTemplateInterfaceCommand (wip)
Line 8:
Line 9: core: add NetworkLinking to AddVmInterfaceCommand
please remove this line.
Line 10:
Line 11: - canDoAction-
Line 12: If "UnlinkingSupported" is false for the cluster compatibility version.
Line 13: - block 'null' network.
--
To view, visit http://gerrit.ovirt.org/9565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39e63f5061b694457de5918490e08bce3fb962c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
