Ayal Baron has posted comments on this change. Change subject: core: GetAllFromExportDomainQueryParameters.getAll ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java Line 10: import org.ovirt.engine.core.bll.command.utils.StorageDomainSpaceChecker; Line 11: import org.ovirt.engine.core.bll.job.ExecutionHandler; Line 12: import org.ovirt.engine.core.bll.network.VmInterfaceManager; Line 13: import org.ovirt.engine.core.bll.quota.QuotaConsumptionParameter; Line 14: import org.ovirt.engine.core.bll.quota.QuotaStorageConsumptionParameter; why don't we have a test that fails compilation in case imports are not ordered? should be easy enough and remove the need for changing this all the time. Line 15: import org.ovirt.engine.core.bll.quota.QuotaStorageDependent; Line 16: import org.ovirt.engine.core.bll.utils.VmDeviceUtils; Line 17: import org.ovirt.engine.core.bll.validator.StorageDomainValidator; Line 18: import org.ovirt.engine.core.common.AuditLogType; -- To view, visit http://gerrit.ovirt.org/9625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cb36d7a5b1a9e309a7553fc2ef696b1cc1cae5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
