Roy Golan has posted comments on this change.
Change subject: engine: revisit improving VDSM error handling
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java
Line 99: PrintReturnValue();
Line 100: throw new VDSProtocolException(ex);
Line 101: } catch (XmlRpcRunTimeException ex) {
Line 102: Throwable rootCause = ExceptionUtils.getRootCause(ex);
Line 103: VDSNetworkException networkException = new
VDSNetworkException(rootCause);
this was the original behaviour prior to the my bad fix so its back to normal
actually. no risk.
Line 104: if ((ex.isNetworkError() || rootCause instanceof
IOException)) {
Line 105: log.debugFormat(msgFormat,
Line 106: getCommandName(),
Line 107: getAdditionalInformation(),
--
To view, visit http://gerrit.ovirt.org/9723
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9df04879b15575842da1bd53c39c00a6623374e0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
