Michael Kublin has uploaded a new change for review. Change subject: engine: Improved a query during SPM election ......................................................................
engine: Improved a query during SPM election I replaced a not efficient code with more efficient code at spm election part. Change-Id: I33ad24b24edb51e3d7805a8967c0f4f7613f6fdb Signed-off-by: Michael Kublin <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 4 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/61/9761/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java index d741656..c0b2804 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java @@ -548,17 +548,6 @@ } } - private List<VDS> GetNonOperationalVdssInPool() { - List<VDS> allVds = DbFacade.getInstance().getVdsDao().getAll(); - List<VDS> nonOperationalvdsInPool = new ArrayList<VDS>(); - for (VDS vds : allVds) { - if (VDSStatus.NonOperational == vds.getstatus() && _storagePoolId.equals(vds.getstorage_pool_id())) { - nonOperationalvdsInPool.add(vds); - } - } - return nonOperationalvdsInPool; - } - /** * Returns True if there are other vdss in pool */ @@ -807,7 +796,10 @@ // if the host which is marked as SPM by the storage is // non operational we want to find it as well if (spmVds == null) { - List<VDS> nonOperationalVds = GetNonOperationalVdssInPool(); + List<VDS> nonOperationalVds = + DbFacade.getInstance() + .getVdsDao() + .getAllForStoragePoolAndStatus(_storagePoolId, VDSStatus.NonOperational); for (VDS tempVds : nonOperationalVds) { if (tempVds.getvds_spm_id() == spmId) { spmVds = tempVds; -- To view, visit http://gerrit.ovirt.org/9761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33ad24b24edb51e3d7805a8967c0f4f7613f6fdb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
