Aravinda VK has posted comments on this change.

Change subject: tools: adding gluster logs
......................................................................


Patch Set 2: (2 inline comments)

Removed gluster_enabled set method and added the logic to set gluster_enabled 
flag in init method itself.

....................................................
File src/rhev/helper/hypervisors.py
Line 62:         self.datacenters.add(dc_obj)
Line 63: 
Line 64:     def add_cluster(self, cluster):
Line 65:         c_obj = self.Cluster(cluster.id, cluster.name)
Line 66: 
Done
Line 67:         # Collect the Gluster support details
Line 68:         if cluster.get_gluster_service():
Line 69:             c_obj.set_gluster_enabled()
Line 70: 


....................................................
File src/rhev/logcollector.py
Line 691:                                        self.conf.get("user"),
Line 692:                                        self.conf.get("passwd"),
Line 693:                                        self.conf.get("engine_ca"),
Line 694:                                        self.conf.get("insecure"))
Line 695:         
Done
Line 696:         except Exception, e:
Line 697:             ExitCodes.exit_code=ExitCodes.WARN
Line 698:             logging.error("_get_hypervisors_from_api: %s" % e)
Line 699:             return set()


--
To view, visit http://gerrit.ovirt.org/9765
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756aea7457c2cd7c9c7b0b842149110f5f392abb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Aravinda VK <avish...@redhat.com>
Gerrit-Reviewer: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to