Ori Liel has uploaded a new change for review.

Change subject: restapi: RSDL - Actions Response-Type should be 'Action'
......................................................................

restapi: RSDL - Actions Response-Type should be 'Action'

Change-Id: Iee693ee4c084a625617d136215cacb8a60cfd3f6
Signed-off-by: Ori Liel <[email protected]>
---
M 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/9796/1

diff --git 
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
 
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
index 0501117..cfa99ac 100644
--- 
a/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
+++ 
b/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/rsdl/RsdlBuilder.java
@@ -308,7 +308,7 @@
             } else if (m.isAnnotationPresent(Path.class)) {
                 String path = m.getAnnotation(Path.class).value();
                 if (isAction(m)) {
-                    handleAction(prefix, results, returnTypeStr, path);
+                    handleAction(prefix, results, path, m);
                 } else {
                     if (isSingleEntityResource(m)) {
                         path = "{" + getSingleForm(prefix) + ":id}";
@@ -327,7 +327,10 @@
         }
     }
 
-    private void handleAction(String prefix, Collection<DetailedLink> results, 
String returnValueStr, String path) {
+    private void handleAction(String prefix, Collection<DetailedLink> results, 
String path, Method m) {
+        Class<?>[] parameterTypes = m.getParameterTypes();
+        assert (parameterTypes.length == 1);
+        String returnValueStr = parameterTypes[0].getSimpleName();
         results.add(new RsdlBuilder.LinkBuilder().url(prefix + "/" + 
path).rel(path).requestParameter(ACTION).responseType(returnValueStr).httpMethod(HttpMethod.POST).build());
     }
 


--
To view, visit http://gerrit.ovirt.org/9796
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee693ee4c084a625617d136215cacb8a60cfd3f6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to