Liron Aravot has posted comments on this change.
Change subject: core: Unit test ImagesHandler.getSuggestedAlias
......................................................................
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
Line 21: }
Line 22:
Line 23: @Test
Line 24: public void testGetSuggestedDiskAliasNullDisk() {
Line 25: assertEquals("null disk does not give the default name",
can you make use here of the constants declared in images handler?
DISK/DefaultDriveName so changing the constants there wouldn't make us need to
change the test as well?
Line 26: prefix + "_Disk1",
Line 27: ImagesHandler.getSuggestedDiskAlias(null, prefix, 1));
Line 28: }
Line 29:
--
To view, visit http://gerrit.ovirt.org/9273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2a1147c022f4cdb7c5658818667af4b51e6aac
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
