Livnat Peer has posted comments on this change. Change subject: engine: Re-define action groups for Network ......................................................................
Patch Set 4: (1 inline comment) We need to understand if gluster mode does not require network related roles. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java Line 72: // storage pool actions groups Line 73: CREATE_STORAGE_POOL(700, RoleType.ADMIN, VdcObjectType.StoragePool, true, ApplicationMode.VirtOnly), Line 74: DELETE_STORAGE_POOL(701, RoleType.ADMIN, VdcObjectType.StoragePool, true, ApplicationMode.VirtOnly), Line 75: EDIT_STORAGE_POOL_CONFIGURATION(702, RoleType.ADMIN, VdcObjectType.StoragePool, true, ApplicationMode.VirtOnly), Line 76: CONFIGURE_STORAGE_POOL_NETWORK(703, RoleType.ADMIN, VdcObjectType.Network, true, ApplicationMode.VirtOnly), why is this virtOnly? Can we get input from Gluster guys to see if they are interested in this as well? This comment is relevant to DELETE/CREATE_STORAGE_POOL_NETWORK and ASSIGN_CLUSTER_NETWORK as well. Line 77: CREATE_STORAGE_POOL_NETWORK(704, RoleType.ADMIN, VdcObjectType.StoragePool, true, ApplicationMode.VirtOnly), Line 78: DELETE_STORAGE_POOL_NETWORK(705, RoleType.ADMIN, VdcObjectType.Network, true, ApplicationMode.VirtOnly), Line 79: Line 80: // engine generic -- To view, visit http://gerrit.ovirt.org/9534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68d96cfd0c028f3e23a12240c2f2ec5ea305dcc2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
