Livnat Peer has posted comments on this change.
Change subject: engine: Modify Network Assign to Cluster Command permissions
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java
Line 162: }
Line 163:
Line 164: @Override
Line 165: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 166:
I think that if the network exist you should be able to edit the (attach)
parameters if you have permission on the network or if you have permission on
the cluster
Line 167: if (networkExists()) {
Line 168: return Collections.singletonList(new
PermissionSubject(getParameters().getVdsGroupId(),
Line 169: VdcObjectType.VdsGroups,
Line 170: ActionGroup.CONFIGURE_CLUSTER_NETWORK));
--
To view, visit http://gerrit.ovirt.org/9540
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff1edaeaf323a7a5b7c407e06d2ff9e3dae3430a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
