Moti Asayag has posted comments on this change. Change subject: engine: Restrict viewable networks by the User ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/dbscripts/create_views.sql Line 1431: AND network.name = vm_interface_view.network_name; Line 1432: Line 1433: -- Permissions on Networks Line 1434: -- The user has permissions on the Network directly Line 1435: CREATE OR REPLACE VIEW user_network_permissions_view_base (entity_id, granted_id) No. Such tests haven't been performed. The actions requires this permissions is adding a vNic to a VM/Template by the user or listing the networks entities from rest-api. If an alternate solution is suggested to the MLA queries, this also should be changed to fit that. Line 1436: AS Line 1437: SELECT object_id, ad_element_id Line 1438: FROM permissions_view Line 1439: WHERE object_type_id = 20 AND role_type = 2 -- To view, visit http://gerrit.ovirt.org/9545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I542e687da8f51dd83e66d813c769275736abc114 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
