Daniel Erez has posted comments on this change.

Change subject: webadmin: "No message" is displayed in Japanese environment
......................................................................


Patch Set 2: (1 inline comment)

....................................................
Commit Message
Line 7: webadmin: "No message" is displayed in Japanese environment
Line 8: 
Line 9: New/Edit VM dialog -> fill a japanese chars into the description
Line 10: field. An error dialog with message "No message" will be displayed.
Line 11: 
* Is it happening only in this specific scenario?
  (i.e. Japanese chars on description box)
* Which canDoActionMessagesare are sent by the backend?
Line 12: The problem was, that the ErrorTranslator expected, that when a message
Line 13: is in form: "$AAA b" is a variable $AAA with value "b". Than it 
expected
Line 14: that the ${AAA} in other messages can be replaced by "b". The problem
Line 15: was, that the decision, if the specific message is a variable 
declaration


--
To view, visit http://gerrit.ovirt.org/9818
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04b32be4cf4c05873bcf9643dd5b9acb3695a54a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to