Moti Asayag has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
......................................................................
Patch Set 18: (5 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 112: @Column(name = "is_delete_protected")
Line 113: private boolean deleteProtected;
Line 114:
Line 115: @Column(name = "db_generation")
Line 116: private Long db_generation;
please comply with java naming conventions
s/db_generation/dbGeneration
Line 117:
Line 118: @Column(name = "is_smartcard_enabled")
Line 119: private boolean smartcardEnabled;
Line 120:
Line 229: this.deleteProtected = deleteProtected;
Line 230: setQuotaId(quotaId);
Line 231: }
Line 232:
Line 233: public Long getDb_generation() {
same
Line 234: return db_generation;
Line 235: }
Line 236:
Line 237: public void setDb_generation(Long db_generation) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 946: public void setNiceLevel(int value) {
Line 947: this.vmStatic.setnice_level(value);
Line 948: }
Line 949:
Line 950: public void setDb_generation(long value) {
please comply with java naming conventions
s/setDb_generation/setDbGeneration
Line 951: this.vmStatic.setDb_generation(value);
Line 952: }
Line 953:
Line 954: public Long getDb_generation() {
Line 950: public void setDb_generation(long value) {
Line 951: this.vmStatic.setDb_generation(value);
Line 952: }
Line 953:
Line 954: public Long getDb_generation() {
same
Line 955: return vmStatic.getDb_generation();
Line 956: }
Line 957:
Line 958: public MigrationSupport getMigrationSupport() {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateVMVDSCommandParameters.java
Line 3: import org.ovirt.engine.core.compat.*;
Line 4:
Line 5: import java.util.List;
Line 6: import java.util.HashMap;
Line 7: import java.util.Map;
this change could have done in a separate patch and to reduce this patch's size
Line 8:
Line 9: public class UpdateVMVDSCommandParameters extends
StorageDomainIdParametersBase {
Line 10: public UpdateVMVDSCommandParameters(Guid storagePoolId,
Line 11: Map<Guid, KeyValuePairCompat<String, List<Guid>>>
infoDictionary) {
--
To view, visit http://gerrit.ovirt.org/9328
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b5132300fb1f1fd94f771cab15efe5246dbeca8
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: liron aravot <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
