Livnat Peer has posted comments on this change. Change subject: engine: vmstatic and vmbase cleanup ......................................................................
Patch Set 2: Looks good to me, but someone else must approve Hi Laszlo, This is a great clean-up. My only concern here is the regressions such a patch can cause. When verifying it can you please test the VM search functionality and the UI VM main tab in general. There is a lot more to do around this clean-up, but I don't think it should hold back this patch. we can clean it in future patches. The only reason I'm not giving +2 is that I would like someone from the UI to take a look as well. -- To view, visit http://gerrit.ovirt.org/9824 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b75b583819587b53cd33124d5536d4e114d3494 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Sharad Mishra <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
