Liron Aravot has posted comments on this change.

Change subject: core: Remove global lock on SPM calls from engine side
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 452: 
Line 453:         public boolean failover(Guid currentCommandSpmId, Set<Guid> 
mTriedVdssList) {
Line 454:             synchronized (syncObj) {
Line 455:                 mTriedVdssList.add(currentCommandSpmId);
Line 456:                 if (currentCommandSpmId.equals(mCurrentVdsId)) {
line 457  performs getHasVdssForSpmSelection(mCurrentVdsId, mTriedVdssList) 
then in line 461 if mCurrentVdsId == null it will return false,
seems to me like there's no need to query and check for possible vdss if we can 
first check if it's null or not
Line 457:                     if (getHasVdssForSpmSelection(mCurrentVdsId, 
mTriedVdssList)) {
Line 458:                         Guid vdsId = mCurrentVdsId;
Line 459:                         nullifyInternalProxies();
Line 460:                         boolean performFailover = false;


--
To view, visit http://gerrit.ovirt.org/9298
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9779fa4b5a4da2ef3ca1d62fe5203a3949ce278
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Daniel Paikov <pai...@gmail.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to