Maor Lipchuk has uploaded a new change for review. Change subject: core:StorageHelper Cleanup, method name standard(3). ......................................................................
core:StorageHelper Cleanup, method name standard(3). Change method name runForSingleConnectionInHost to be compatible with the java standards. Change-Id: Ia61b4a6536f1539144b9a72a622c2ec144a9b0fe Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/10127/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java index 138529a..2cf1421 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java @@ -201,13 +201,13 @@ @Override public boolean connectStorageToDomainByStoragePoolId(storage_domains storageDomain, Guid storagePoolId) { - return RunForSingleConnectionInHost(storageDomain, storagePoolId, + return runForSingleConnectionInHost(storageDomain, storagePoolId, VDSCommandType.ConnectStorageServer.getValue()); } @Override public boolean disconnectStorageFromDomainByStoragePoolId(storage_domains storageDomain, Guid storagePoolId) { - return RunForSingleConnectionInHost(storageDomain, storagePoolId, + return runForSingleConnectionInHost(storageDomain, storagePoolId, VDSCommandType.DisconnectStorageServer.getValue()); } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java index f7d57c3..04b6b4e 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java @@ -24,10 +24,10 @@ public abstract class StorageHelperBase implements IStorageHelper { @Override public boolean connectStorageToDomainByStoragePoolId(storage_domains storageDomain, Guid storagePoolId) { - return RunForSingleConnectionInHost(storageDomain, storagePoolId, VdcActionType.ConnectStorageToVds.getValue()); + return runForSingleConnectionInHost(storageDomain, storagePoolId, VdcActionType.ConnectStorageToVds.getValue()); } - public boolean RunForSingleConnectionInHost(storage_domains storageDomain, Guid storagePoolId, int type) { + public boolean runForSingleConnectionInHost(storage_domains storageDomain, Guid storagePoolId, int type) { boolean returnValue = false; storage_pool pool = DbFacade.getInstance().getStoragePoolDao().get(storagePoolId); Guid vdsId = pool.getspm_vds_id() != null ? pool.getspm_vds_id().getValue() : Guid.Empty; @@ -40,7 +40,7 @@ @Override public boolean disconnectStorageFromDomainByStoragePoolId(storage_domains storageDomain, Guid storagePoolId) { - return RunForSingleConnectionInHost(storageDomain, storagePoolId, + return runForSingleConnectionInHost(storageDomain, storagePoolId, VdcActionType.RemoveStorageServerConnection.getValue()); } -- To view, visit http://gerrit.ovirt.org/10127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia61b4a6536f1539144b9a72a622c2ec144a9b0fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
