Mike Kolesnik has posted comments on this change.
Change subject: engine: Add GetVmGuestAgentInterfacesByVmIdQuery
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmGuestAgentInterfacesByVmIdQueryTest.java
Line 26: @Before
Line 27: @Override
Line 28: public void setUp() throws Exception {
Line 29: super.setUp();
Line 30: when(getQuery().getDbFacade()).thenReturn(dbFacade);
You can use getDbFacadeMockInstance() instead of mocking it yourself
Line 31:
when(dbFacade.getVmGuestAgentInterfaceDao()).thenReturn(vmGuestAgentInterfaceDao);
Line 32: }
Line 33:
Line 34: @Test
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmGuestAgentInterfacesByVmIdParameters.java
Line 1: package org.ovirt.engine.core.common.queries;
Line 2:
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GetVmGuestAgentInterfacesByVmIdParameters extends
VdcQueryParametersBase {
You can use IdQueryParameters instead of creating YAIPC (Yet Another Id
Parameter Class)
Line 6: private static final long serialVersionUID = -4575932839901418416L;
Line 7: private Guid vmId = new Guid();
Line 8:
Line 9: public GetVmGuestAgentInterfacesByVmIdParameters() {
--
To view, visit http://gerrit.ovirt.org/10099
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4edbdf818495c04ad2230a92bd63791fad006f5e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
