Yair Zaslavsky has uploaded a new change for review. Change subject: [WIP] core: Improving MacPoolManager initialization ......................................................................
[WIP] core: Improving MacPoolManager initialization Instead of getting all Vms, and for each vm getting its vm network interface, this patch perform one call to get all vm interfaces Change-Id: I76083f372ed5d9ab124047bcadb03b77e24163f0 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java 1 file changed, 3 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/10188/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java index 8145e9a..e47f8f4 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java @@ -46,13 +46,9 @@ } } - List<VM> vms = DbFacade.getInstance().getVmDao().getAll(); - for (VM vm : vms) { - List<VmNetworkInterface> interfaces = DbFacade.getInstance() - .getVmNetworkInterfaceDao().getAllForVm(vm.getId()); - for (VmNetworkInterface iface : interfaces) { - AddMac(iface.getMacAddress()); - } + List<VmNetworkInterface> interfaces = DbFacade.getInstance().getVmNetworkInterfaceDao().getAll(); + for (VmNetworkInterface iface: interfaces) { + AddMac(iface.getMacAddress()); } mInitialized = true; } -- To view, visit http://gerrit.ovirt.org/10188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I76083f372ed5d9ab124047bcadb03b77e24163f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
