Roy Golan has posted comments on this change. Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm ......................................................................
Patch Set 1: ALlon - I don't agree with the code being redundant. Internal migrate can not be forced, hence the flag is not in used - I dont think we should set it for that. Migrate has its own logic with force which is clear. as a middle way to be even clearer Intenal command can have InternalVmParams which doesn't have the force flag -- To view, visit http://gerrit.ovirt.org/10107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida10d53ccd5321d3ccc510bd2111fa013dcdcdbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
