Eli Mesika has uploaded a new change for review.

Change subject: [WIP] core: RFE: Multi-Tier fencing support
......................................................................

[WIP] core: RFE: Multi-Tier fencing support

This series of patches implements the following RFE
http://wiki.ovirt.org/Features/Design/DetailedHostPMMultipleAgents

This patch is a preparation patch that separates between hostname/ip
validation and NULL check. so the hostname/ip can be applied to fields
that can be NULL

Change-Id: I4fe7e2d25e06fbadad27b607e46b18881ad10957
Signed-off-by: Eli Mesika <[email protected]>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostnameOrIPConstraint.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/10257/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostnameOrIPConstraint.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostnameOrIPConstraint.java
index 56f54c9..095d65b 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostnameOrIPConstraint.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/HostnameOrIPConstraint.java
@@ -14,7 +14,7 @@
 
     @Override
     public boolean isValid(String name, ConstraintValidatorContext context) {
-        return (name != null) && ValidationUtils.validHostname(name);
+        return name == null || ValidationUtils.validHostname(name);
     }
 
 }


--
To view, visit http://gerrit.ovirt.org/10257
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4fe7e2d25e06fbadad27b607e46b18881ad10957
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to